Re: [boost] [locale] Formal review of Boost.Locale library starts tomorrow

Subject: Re: [boost] [locale] Formal review of Boost.Locale library starts tomorrow
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2011-04-08 14:01:38

AMDG

Some minor nits when reading the documentation:

Minor point: The canonical documentation link
is libs/locale/index.html.  This should redirect
to wherever the documentation actually resides.

I see a lot of places where you're using "may"
where "can" would be more appropriate.

Message formatting:
s/is change to/in changed to/

direct translation:
the declarations of ngettext and friends are
missing the int n parameter, which is rather
important.

Character Set Conversions:

Would it make sense to have an additional
alternative of replacing characters that
couldn't be converted with some default
text?  I'm used to seeing ??? and it seems
as though if the text can't be converted
it's better to see that there's something
there than to have it silently disappear.

Boundary analysis:

The last example can't possibly be correct.
It uses map.begin() and map.end() to
initialize map.

Building:

Building with CMake:
s/relay on auto-linking/rely on auto-linking/

Appendix:
Default Encoding under Microsoft Windows:
s/However such behavior may broke/However such behavior may break/

In Christ,
Steven Watanabe