Subject: Re: [boost] [locale] Formal review of Boost.Locale library starts tomorrow
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2011-04-14 23:36:30
-----BEGIN PGP SIGNED MESSAGE-----
On 04/06/2011 02:29 PM, Chad Nelson wrote:
> Please explicitly state in your review whether the library should be
*Yes, the Locale library should be accepted into Boost.*
> - What is your evaluation of the design?
> - What is your evaluation of the implementation?
The design appears well thought out and
the implementation is solid.
> - What is your evaluation of the documentation?
The tutorial was sufficient to understand
what the library could do. The reference
could use more attention to details like
preconditions, postconditions, exception
guarantees, limitations, and so on.
> - What is your evaluation of the potential usefulness of the
Who needs anything other than en-US anyway?
> - Did you try to use the library? With what compiler? Did you
> have any problems?
No. I didn't try it.
> - How much effort did you put into your evaluation? A glance? A
> quick reading? In-depth study?
I spent about 20 hours reading the
entire code base carefully.
> - Are you knowledgeable about the problem domain?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk