Re: [boost] [review] string convert

Subject: Re: [boost] [review] string convert
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-05-03 14:15:39

Jeff Flinn wrote:
> Stewart, Robert wrote:
> > Jeff Flinn wrote:
> >> Stewart, Robert wrote:
> >>> Gordon Woodhull wrote:
>
> >>    // returns empty optional if cast fails
> >>    boost::optional<int> oi = xxx_cast<boost::optional<int>>(s);
> >>
> > I really dislike the repetition of "boost::optional<int>" in
> > that.  What about going a little farther in the dynamic_cast
> > direction (actually, following the boost::get precedent):
> >
> >    int const i(xxx_cast<int>(s)); // throws on failure
> >    boost::optional<int> const oi(xxx_cast<int>(&s));
>
> My gut reaction is that it lacks symmetry.

OK, but it does follow a precedent.

> As mentioned else-thread, doesn't C++ 0x's auto solve the
> repetition entirely, while being explicit as to what's going
> on?
>
> auto oi(xxx_cast<boost::optional<int>>(s));

Yes, though that doesn't help with C++03 code.

> > That name could work, but does it allow for formatting?  IOW,
> > "convert," like "translate," leaves room to consider
> > formatting, including locales.  "Make" suggests something
> > more fixed to me.
>
> I personally don't have those reservations and the
> applicability of Make. Even more concise with perhaps less
> preconceptions might be:
>
>    as<int>(s, 123);

Not bad.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer                     using std::disclaimer;
Dev Tools & Components
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.