Re: [boost] Boost.Context review result

Subject: Re: [boost] Boost.Context review result
From: Holger Grund (holger.grund_at_[hidden])
Date: 2011-05-15 09:54:27

> > 3. The assembler implementation on Windows must be disallowed if the
> ABI bug reported by Holger is confirmed. As far as Windows provides a fiber
> implementation that is as efficient as the assembler one, the assembler
> implementation is not mandatory and the user of the provided Windows
> fiber is a preferable choice.
> >
> > asm impl for windows should be ok - all boost_fcontext_t functions are
> > leaf-functions using tail calls - concerns from Holger do apply only
> > to non-leaf functions
> 
> If the bug is not confirmed, then your library would satisfy this point. I will
> just heard what Holger has to say.
> 
I promised Oliver to get back to him last weekend -- but as usual something got in the way. I only managed to send him some notes this morning.

I think there are a few things that would be worth looking into. In the particular example link_context/boost_fcontext_link is never called directly, so it's probably fine except for unwinding, which I think should be tackled differently. I've explained some concerns off-list and if I get a chance, I'll try out these cases. But that'll be a few days.

Of couse, feel free to ping me off-list as it's pretty hard to keep up with the volume of mails on this list.

Thanks!
-hg