Re: [boost] [exception] warnings on top of trunk

Subject: Re: [boost] [exception] warnings on top of trunk
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2011-05-23 11:01:02

On May 23, 2011, at 7:45 AM, Bryce Lelbach wrote:

> /opt/boost/trunk/stage/gcc-4.4.4-release/include/boost/exception/detail/exception_ptr.hpp: In function ‘void boost::rethrow_exception(const boost::exception_ptr&)’:
> /opt/boost/trunk/stage/gcc-4.4.4-release/include/boost/exception/detail/exception_ptr.hpp:458: warning: ‘noreturn’ function does return
> 
> Is it cool for me to remove this attribute?

Bryce -

Do you mean this function?

>     BOOST_ATTRIBUTE_NORETURN
>     inline
>     void
>     rethrow_exception( exception_ptr const & p )
>         {
>         BOOST_ASSERT(p);
>         p.ptr_->rethrow();
>         }
> 

I don't see any way that function can return. 
Maybe boost::exception::detail::impl::rethrow should be marked "noreturn" instead.

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists_at_[hidden]>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki