Re: [boost] [Boost-commit] svn:boost r72166 - trunk/libs/thread/src/pthread

Subject: Re: [boost] [Boost-commit] svn:boost r72166 - trunk/libs/thread/src/pthread
From: Juergen Hunold (juergen.hunold_at_[hidden])
Date: 2011-05-26 04:57:56

Hi Anthony,

On Wednesday, 25. May 2011 23:19:01 anthony_at_[hidden] wrote:
> Author: anthonyw
> Date: 2011-05-25 17:18:59 EDT (Wed, 25 May 2011)
> New Revision: 72166
> URL: http://svn.boost.org/trac/boost/changeset/72166
> 
> Log:
> extern "C" functions are static
> 
> Text files modified:
>    trunk/libs/thread/src/pthread/once.cpp |     4 ++--
>    1 files changed, 2 insertions(+), 2 deletions(-)
> 
> Modified: trunk/libs/thread/src/pthread/once.cpp
> ===========================================================================
> === --- trunk/libs/thread/src/pthread/once.cpp      (original)
> +++ trunk/libs/thread/src/pthread/once.cpp      2011-05-25 17:18:59 EDT
> (Wed, 25 May 2011) @@ -22,12 +22,12 @@
>              pthread_key_t epoch_tss_key;
>              pthread_once_t epoch_tss_key_flag=PTHREAD_ONCE_INIT;
> 
> -            extern "C" void delete_epoch_tss_data(void* data)
> +            extern "C" static void delete_epoch_tss_data(void* data)

At least gcc-4.5.2 does not like this combination and bails out with:

error: invalid use of 'static' in linkage specification

gcc version 4.5.2 (Ubuntu/Linaro 4.5.2-8ubuntu4) 

Please find a patch fixing this attached.

Okay to commit?

Yours,

Jürgen
-- 
* Dipl.-Math. Jürgen Hunold       ! Ingenieurgesellschaft für 
* voice: ++49 511 262926 57       ! Verkehrs- und Eisenbahnwesen mbH  
* fax  : ++49 511 262926 99       ! Lister Straße 15
* juergen.hunold_at_[hidden]        ! www.ivembh.de
* 
* Geschäftsführer:                ! Sitz des Unternehmens: Hannover
* Prof. Dr.-Ing. Thomas Siefer    ! Amtsgericht Hannover, HRB 56965
* PD Dr.-Ing. Alfons Radtke       !