Re: [boost] [review] Heaps

Subject: Re: [boost] [review] Heaps
From: Thorsten Ottosen (thorsten.ottosen_at_[hidden])
Date: 2011-06-01 09:48:18

Den 01-06-2011 15:04, Tim Blechmann skrev:
> hi thorsten,
>
>> For the documentation, I suggest that pre and postcondition are more
>> clearly stated,
>
> what kind of pre- and postconditions are you refering to? do you have anything
> specific in mind? or is there a library which does this in a very good way?
>
>
>> and that the implementaion checks these with assertions
>> e.g. for increase()/decrease()
>> (didn't look at the source).
>
> ... this is a good point ... i should probably add some sanity checks

I couln't find a precondition in the docs for eg. increase().

>
>> Please also specify clearly what the requirements are for T on which
>> the containers are templated. Is the implementation maximally generic in
>> this area?
>
> i do not really see any restriction on the held type ...

? surely it must support a linear ordering? operator<?

-Thorsten