Re: [boost] [review] Heaps

Subject: Re: [boost] [review] Heaps
From: Tim Blechmann (tim_at_[hidden])
Date: 2011-06-17 03:50:56

hi all,

i do have a few questions regarding the integration of boost.heap into boost:

* i am using assertions. some of them verify the internal logic, some should 
verify the correct usage. at the moment, the internal logic will be verified 
only if BOOST_HEAP_SANITYCHECK is defined. is this reasonable? and shall i use 
BOOST_ASSERT or assert for that?

* shall the sanity checks be enabled for running the unit tests?

* what is the preferred way to implement compile-time dispatching? (a) adding 
static const flags to the class definition, (b) deriving from a special `tag' 
class and use is_base_of or (c) implementing a separate `traits' class. at the 
moment i am using (a), but maybe there is a convention?

thanks, tim