Subject: Re: [boost] [graph] gcc visibility support patch
From: Jürgen Hunold (juergen.hunold_at_[hidden])
Date: 2011-07-23 05:32:57
On Saturday, 23. July 2011 02:14:40 Jeremiah Willcock wrote:
> On Fri, 22 Jul 2011, Jürgen Hunold wrote:
> > Okay to commit?
> Fine with me.
Thanks, done trunk with r73308. Will merge to release when the regression
tests have cycled.
> Is there anything that could be added to the Boost Inspect
> tool (or at least the coding guidelines) to make sure that future code
> does not need visibility patches?
Well, that is an interesting idea.
We could check for
in the library headers.
Those are correctly used in:
to define the BOOST_SYMBOL_EXPORT/-IMPORT macros.
Their usage elsewhere might by necessary, but only in certain circumstances
(exception visibility with msvc or other strange reasons ;-))
I see that I have missed Boost.Chrono and Boost.Asio which were added in the
meantime. A check and an entry in the library guidelines for non-header-only
libraries would be good, too.
-- * Dipl.-Math. Jürgen Hunold ! Ingenieurgesellschaft für * voice: ++49 511 262926 57 ! Verkehrs- und Eisenbahnwesen mbH * fax : ++49 511 262926 99 ! Lister Straße 15 * juergen.hunold_at_[hidden] ! www.ivembh.de * * Geschäftsführer: ! Sitz des Unternehmens: Hannover * Prof. Dr.-Ing. Thomas Siefer ! Amtsgericht Hannover, HRB 56965 * PD Dr.-Ing. Alfons Radtke !