[boost] [Conversion] Review

Subject: [boost] [Conversion] Review
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2011-08-28 03:43:55

First of all, there is already a Boost.Conversion library (released in
1.20.0). Users will be confused, because two libraries have same
names.

* What is your evaluation of the design?

It is simple and looks good. But consider the following situation:
lexical_cast<char>(1) and numeric_cast<char>(1) will produce output.
It must be documented, which cast will your library use in which
cases.
There must be some tags, to allow user to choose, which conversion is
required. There are some dummy::type_tag tags in source code, but
looks like they are not used, and not documented!

* What is your evaluation of the implementation?

Did not look very carefully trough the sources.

* What is your evaluation of the documentation?

There is no documentation about which conversion when used.
convert_to<char>(1) will call numeric_cast or lexical_cast?

* What is your evaluation of the potential usefulness of the library?

Usually user just want to use lexical_cast or numeric_cast.
Situations, when generic conversion is required are less often.

* Did you try to use the library? With what compiler? Did you have any problems?

I did not used it.

* How much effort did you put into your evaluation? A glance? A quick
reading? In-depth study?

A quick reading.

* Are you knowledgeable about the problem domain?

I am knowledgeable about lexical conversions domain. Generic
conversions are close enough to that domain.

* Do you think the library should be accepted as a Boost library?

Yes, it should. But only after the documentation will be updated and
tags added. Until then, it is not clear which cast is when used and
library is not as generic as possible. But such big changes to library
design will require some new short review.