Re: [boost] [Review:Algorithms] Order of args to clamp

Subject: Re: [boost] [Review:Algorithms] Order of args to clamp
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2011-09-26 13:40:25

On Sep 26, 2011, at 9:33 AM, Dave Abrahams wrote:

> 
> on Mon Sep 26 2011, Andrew Sutton <asutton.list-AT-gmail.com> wrote:
> 
>>> It seems to me that a clamp_range is just:
>>> 
>>>        std::transform ( begin, end, out, clamp ( _1, lo, hi ))
>>> 
>>> is that what you meant?
>> 
>> Sorry... this got lost in the thread. That looks like the right
>> implementation, but it might be nice to provide an interface for it:
>> 
>> template<typename Iter, typename T>
>> void clamp_range(Iter first, Iter last, cont T& high, const T& low)
> 
> IMO it clearly should be:
> 
> template<typename Iter>
> void clamp_range(
>     Iter first, Iter last, 
>     typename itertor_traits<Iter>::value_type const& high, 
>     typename itertor_traits<Iter>::value_type const& low)

BTW, clamp_range defined like this fails on the following code:

        int inputs [] = { 0, 1, 2, 3, 4 };
        clamp_range ( &inputs[0], &inputs[5], 2, 4 );

because pointers are not iterators.
[ I could write a variant that takes pointers, but I'm already seeing four variants, this will add a couple more ]

        clamp_range ( iter, iter, lo, hi );
        clamp_range ( iter, iter, lo, hi, pred );
        clamp_range ( range, lo, hi );
        clamp_range ( range, lo, hi, pred );

        clamp_range ( T*, T*, lo, hi );
        clamp_range ( T*, T*, lo, hi, pred );

Comments?

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists_at_[hidden]>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki