Re: [boost] [Review:Algorithms] Boost.Algorithms Review

Subject: Re: [boost] [Review:Algorithms] Boost.Algorithms Review
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-10-02 18:51:07

Marshall Clow wrote:
> On Oct 1, 2011, at 4:58 PM, Stewart, Robert wrote:
>
> > You presume that all C++ implementations with a specific
> > value of __cplusplus provide std::all_of, std::any_of, and
> > std::none_of.  Is that portable?
>
> I got that from n3290, which says in section 16.8 (predefined
> macro names):
>
> __cplusplus
> The name __cplusplus is defined to the value 201103L when
> compiling a C++ translation unit. [157]
[snip]
> On the other hand, if Boost.Config has a specific "compiling
> with C++11" flag, using that would be better. I couldn't find
> one, though.

A Boost.Config macro that indicates when those algorithms are supplied would be ideal.  I wonder, for example, whether compilers might define __cplusplus to that value without complete language support.

> > I was expecting more algorithm documentation in search.hpp.
[snip]
> There are some links there.
> I have no problems with adding more - until it starts
> obscuring the code ;-)
>
> For example in search.hpp, line 147:
> /*
>     A templated version of the boyer-moore searching
> algorithm.
>
> References:
>     http://www.cs.utexas.edu/users/moore/best-ideas/string-
> searching/
>     http://www.cs.utexas.edu/~moore/publications/fstrpos.pdf
>
> Explanations:   boostinspect:noascii (test tool complains)
>     http://en.wikipedia.org/wiki/Boyer-
> Moore_string_search_algorithm
>     http://www.movsd.com/bm.htm
>     http://www.cs.ucdavis.edu/~gusfield/cs224f09/bnotes.pdf
>
> and so on

I missed that.  I was further into the file before I noticed the apparent lack.  Things do decay on the Internet, however, so it would be useful to capture titles for each of the URLs to make finding alternative locations easier, in the future, should that become necessary.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer                     using std::disclaimer;
Dev Tools & Components
Susquehanna International Group, LLP  http://www.sig.com

________________________________

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.