Re: [boost] [date_time] warning removal

Subject: Re: [boost] [date_time] warning removal
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2012-04-21 16:48:07

Le 09/04/12 18:15, Vicente J. Botet Escriba a écrit :
> Hi,
>
> Attached a patch to remove most of the warnings below. Could I commit it?

Hi,

any new on this patch,

Best,
Vicente
> There are 4 warnings I want to check
>
> ../../../boost/date_time/period_formatter.hpp:117:47: warning: unused 
> parameter 'separator' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:118:47: warning: unused 
> parameter 'start_delim' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:119:47: warning: unused 
> parameter 'open_end_delim' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:120:47: warning: unused 
> parameter 'closed_end_delim' [-Wunused-parameter]
>
> where
>
>     void delimiter_strings(const string_type& separator,
>                            const string_type& start_delim,
>                            const string_type& open_end_delim,
>                            const string_type& closed_end_delim)
>     {
>       m_period_separator;
>       m_period_start_delimeter;
>       m_open_range_end_delimeter;
>       m_closed_range_end_delimeter;
>     }
>
> and
>
>   private:
>     range_display_options m_range_option;
>     string_type m_period_separator;
>     string_type m_period_start_delimeter;
>     string_type m_open_range_end_delimeter;
>     string_type m_closed_range_end_delimeter;
>   };
>
>
> Is an assignment missing or it was a typo while trying to avoid the 
> warning?
>
> Best,
> Vicente
>
> ../../../boost/date_time/date.hpp:194:55: warning: extra ';' inside a 
> class [-pedantic]
> ../../../boost/date_time/date.hpp:195:67: warning: extra ';' inside a 
> class [-pedantic]
> ../../../boost/date_time/date_duration.hpp:128:57: warning: extra ';' 
> inside a struct [-pedantic]
> ../../../boost/date_time/date_duration.hpp:138:69: warning: extra ';' 
> inside a struct [-pedantic]
> ../../../boost/date_time/date_duration.hpp:35:73: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_generators.hpp:37:30: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_generators.hpp:38:39: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_iterator.hpp:43:32: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_iterator.hpp:56:45: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_iterator.hpp:57:48: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_names_put.hpp:233:8: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/date_names_put.hpp:45:26: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/dst_transition_generators.hpp:21:38: warning: 
> extra ';' inside a class [-pedantic]
> ../../../boost/date_time/local_time/custom_time_zone.hpp:46:7: 
> warning: extra ';' inside a class [-pedantic]
> ../../../boost/date_time/local_time/custom_time_zone.hpp:47:40: 
> warning: extra ';' inside a class [-pedantic]
> ../../../boost/date_time/local_time/local_date_time.hpp:211:31: 
> warning: extra ';' inside a class [-pedantic]
> ../../../boost/date_time/local_time/posix_time_zone.hpp:118:39: 
> warning: extra ';' inside a class [-pedantic]
> ../../../boost/date_time/period_formatter.hpp:117:47: warning: unused 
> parameter 'separator' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:118:47: warning: unused 
> parameter 'start_delim' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:119:47: warning: unused 
> parameter 'open_end_delim' [-Wunused-parameter]
> ../../../boost/date_time/period_formatter.hpp:120:47: warning: unused 
> parameter 'closed_end_delim' [-Wunused-parameter]
> ../../../boost/date_time/time_duration.hpp:254:57: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:22:77: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:33:45: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:34:48: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:35:64: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:36:65: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:37:66: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:38:65: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:39:64: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_iterator.hpp:40:65: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_zone_base.hpp:42:24: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/time_zone_base.hpp:43:33: warning: extra ';' 
> inside a class [-pedantic]
> ../../../boost/date_time/wrapping_int.hpp:37:42: warning: extra ';' 
> inside a class [-pedantic]
>