|
Boost : |
Subject: Re: [boost] [release] scope_exit, local_function, utility/identity_type, and functional/overloaded_function
From: lcaminiti (lorcaminiti_at_[hidden])
Date: 2012-04-30 20:59:53
Daniel James-3 wrote
>
>> For all of those, I've followed the checklist so I've run the code
>> inspection tool, updated all docs, librariers.htm, and maintainers.txt.
>
> Looks fine, (at least it did when I looked last week). I did find the
> way you force some tests to fail a bit odd, why don't you just let
> them fail naturally?
>
Which tests?
Some ScopeExit and LocalFunction requires variadic macros and C++11 lambdas
so I used Boost.Config to detect if these are not supported and fail these
tests with
#error "variadic macros required"
or
#error "lambda functions required"
I find these errors more readable than the ugly ones the libraries will
generate otherwise. The point is that users should not use some library
features at all without variadic macros or lambda functions (so if the
libraries generate nasty errors when the regression tests check these
features blindly on all compilers).
Are these the tests you are referring to?
Thanks.
--Lorenzo
-- View this message in context: http://boost.2283326.n4.nabble.com/boost-release-scope-exit-local-function-utility-identity-type-and-functional-overloaded-function-tp4572011p4599842.html Sent from the Boost - Dev mailing list archive at Nabble.com.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk