Re: [boost] Review Request : Boost.Range Extension

Subject: Re: [boost] Review Request : Boost.Range Extension
From: Akira Takahashi (faithandbrave_at_[hidden])
Date: 2012-06-02 01:34:47

2012/6/1 Michel Morin <mimomorin_at_[hidden]>:
> Akira Takahashi wrote:
>> Source Code:
>> https://github.com/faithandbrave/OvenToBoost
>
> Small nitpicking:
>
> [adaptor/dropped_while.hpp]
> * Don't forget `#pragma warning(pop)`.
>
> [as_container.hpp]
> * Missing include guard.
>
> [detail/indirect_functor.hpp]
> * Use `BOOST_NO_XXXX` to detect C++11 features (`BOOST_HAS_XXXX` is
> deprecated).
> * Even if a compiler supports C++11, the availability of `std::forward` in
> the standard library is not guaranteed. Use `static_cast` as substitute of
> `std::forward`. (Or just abandon such a pathological case and use
> `std::forward`.)
>

Thanks for many review.
Fixed!