Re: [boost] [thread] patch to suppress msvc warnings

Subject: Re: [boost] [thread] patch to suppress msvc warnings
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2012-09-22 17:35:42

Le 22/09/12 18:24, Jürgen Hunold a écrit :
> Hi Vicente,
>
> On Saturday, 22. September 2012 18:08:06 Vicente J. Botet Escriba wrote:
>> Le 22/09/12 17:31, Jürgen Hunold a écrit :
>>> boost/thread/win32/thread_data.hpp(90) : warning C4251:
>>> 'boost::detail::thread_data_base::thread_handle' : class
>>> 'boost::detail::win32::handle_manager' needs to have dll-interface to be
>>> used by clients of struct 'boost::detail::thread_data_base'
>> Yes, you can. But i will prefer to find out how to give dll-interface
>> to? Do you know what can be done?
> Sorry, this can be fixed by adding BOOST_THREAD_DECL. Patch attached.
>
> The rest are false positives from the standard library which have irritated
> me.
>
> Example:
>
> class 'std::vector<_Ty>' needs to have dll-interface to be used by clients of
> struct 'boost::detail::thread_data_base'
>
> and the same for std::map<> . Those can only be suppressed. See previous
> patch.
>
I believed that BOOST_THREAD_DECL was only needed for classes with 
definitions on the .cxx files.

Ok, commit them then.

Best,
Vicente