Re: [boost] Boost.Test updates in trunk: need for (mini) review?

Subject: Re: [boost] Boost.Test updates in trunk: need for (mini) review?
From: Ian Emmons (iemmons_at_[hidden])
Date: 2012-10-29 11:29:23

On Oct 27, 2012, at 7:22 PM, Dave Abrahams wrote:
> On Fri Oct 26 2012, Rob Stewart <robertstewart-AT-comcast.net> wrote:
>> On Oct 26, 2012, at 8:41 AM, Ian Emmons <iemmons_at_[hidden]> wrote:
>>> On Oct 19, 2012, at 11:03 PM, Gennadiy Rozenal wrote:
>>> 
>>>> e) zip - dataset constructed by zipping 2 datasets of the same size, but not 
>>>>       necessarily the same type
>>>> 
>>>> This dataset has an arity which is sum of argument dataset arities.
>>>> 
>>>> int   a[] = {1,2,3};
>>>> char* b[] = {"qwe", "asd", "zxc"};
>>>> 
>>>> data::make(a) ^ data::make(b)
>>>> dataset with 3 samples which are pairs of int and char*.
>>> 
>>> Calling this "zipping" is odd (at least to me).  Makes it sound like
>>> a compression facility.  Perhaps "tupling" would be better.
>> 
>> Tupling sounds very odd to me. "Zipping" is well established for
>> merging of this sort.
> 
> Yes, "zip" is a well-established concept.

Great -- "zip" it is.  (One more thing to add to the long list of stuff I've never heard of.)

>>> I also think the choice of operator here is not ideal.  How does the
>>> xor operator evoke any notion of this operation?
>> 
>> The circumflex has two tails that merge at the top.
> 
> :-) by that measure,
> 
>> =
> 
> would be a good choice too.  That said, I have no problem with the circumflex.

Agreed -- I like the comparison to an upside-down zipper.  Perhaps mentioning that in the docs would be a useful thing.