Re: [boost] [atomic, x86] need another pair of eyes

Subject: Re: [boost] [atomic, x86] need another pair of eyes
From: Peter Dimov (lists_at_[hidden])
Date: 2012-12-19 07:00:34

Andrey Semashev wrote:
On Wed, Dec 19, 2012 at 3:27 PM, Peter Dimov <lists_at_[hidden]> wrote:
> > Where (file/line) is the mfence that can be removed?
>
> atomic/detail/windows.hpp, line 174.
>
> Comparing it to gcc-x86.hpp, the gcc implementation indeed doesn't
> have it, so I'm probably right.

It doesn't seem necessary, but it's only used at one place, in 
atomic_flag::clear.

All uses of READ_BARRIER or WRITE_BARRIER seem wrong, though. 
READ_WRITE_BARRIER is needed in all places where these are used.