[boost] [Release managers] Permission to rollback Boost.Thread breaking changes

Subject: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2012-12-31 05:25:31

Hi,

I would like to apply the following patch to trunk and release branch to 
avoid the Boost.Thread breaking changes.

* [@http://svn.boost.org/trac/boost/ticket/6229 #6229] Rename the 
unique_future to future following the c++11.
* [@http://svn.boost.org/trac/boost/ticket/6266 #6266] Breaking change: 
thread destructor should call terminate if joinable.
* [@http://svn.boost.org/trac/boost/ticket/6269 #6269] Breaking change: 
thread move assignment should call terminate if joinable.

This will let us the time to discuss the best way to manage with this 
breaking changes.

Is someone against this late change?

Best,
Vicente

svn diff boost/thread libs/thread
Index: boost/thread/detail/config.hpp
===================================================================
--- boost/thread/detail/config.hpp    (revision 82295)
+++ boost/thread/detail/config.hpp    (working copy)
@@ -78,9 +78,9 @@
  #define BOOST_THREAD_RVALUE_REFERENCES_DONT_MATCH_FUNTION_PTR
  #endif

-// Default version is 3
+// Default version
  #if !defined BOOST_THREAD_VERSION
-#define BOOST_THREAD_VERSION 3
+#define BOOST_THREAD_VERSION 2
  #else
  #if BOOST_THREAD_VERSION!=2  && BOOST_THREAD_VERSION!=3 && 
BOOST_THREAD_VERSION!=4
  #error "BOOST_THREAD_VERSION must be 2, 3 or 4"
Index: libs/thread/src/win32/thread.cpp
===================================================================
--- libs/thread/src/win32/thread.cpp    (revision 82295)
+++ libs/thread/src/win32/thread.cpp    (working copy)
@@ -12,7 +12,7 @@
  #ifndef WINVER
  #define WINVER 0x400
  #endif
-#define BOOST_THREAD_VERSION 3
+//#define BOOST_THREAD_VERSION 3

  #include <boost/thread/thread.hpp>
  #include <boost/thread/once.hpp>
Index: libs/thread/src/pthread/thread.cpp
===================================================================
--- libs/thread/src/pthread/thread.cpp    (revision 82295)
+++ libs/thread/src/pthread/thread.cpp    (working copy)
@@ -6,7 +6,7 @@
  //  Distributed under the Boost Software License, Version 1.0. (See 
accompanying
  //  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)

-#define BOOST_THREAD_VERSION 3
+//#define BOOST_THREAD_VERSION 3
  #include <boost/thread/detail/config.hpp>

  #include <boost/thread/thread.hpp>