Re: [boost] *BSD detail/endian.hpp header patch looking for review

Subject: Re: [boost] *BSD detail/endian.hpp header patch looking for review
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2013-02-17 12:36:21

Le 17/02/13 18:16, Brad Smith a écrit :
> On Sun, Feb 17, 2013 at 05:54:29PM +0100, Lars Viklund wrote:
>> On Sun, Feb 17, 2013 at 11:39:36AM -0500, Brad Smith wrote:
>>> On Sun, Feb 17, 2013 at 05:33:10PM +0100, Vicente J. Botet Escriba wrote:
>>>> Le 17/02/13 15:53, Brad Smith a ?crit :
>>>>> On Sun, Feb 17, 2013 at 01:31:50PM +0100, Vicente J. Botet Escriba wrote:
>>>>>> Le 16/02/13 20:57, Brad Smith a ?crit :
>>>>>>> Hi,
>>>>>>>
>>>>>>> There is a patch for the detail/endian.hpp header for *BSD OS's
>>>>>>> in ticket 6013 that needs review and to be commited. Anyone able
>>>>>>> to help out here?
>>>>>>>
>>>>>> Which Boost library (component) are you using that needs this patch?
>>>>> This was already answered in the ticket.
>>>>>
>>>> I've requested here again, as I don't find the answer in the ticket.
>>> "The same code that uses this header in the first place."
>> Would you please stop channeling Theo and instead just answer with
>> clarifications? While this might be acceptable behaviour in whatever
>> organization you work in, it's not acceptable here. Be nice and helpful.
>>
>> Annoying contributors won't help getting them to go out of their way to
>> aid in getting patches integrated.
> $ find . -exec grep "boost/detail/endian.hpp" {} \; -print
> #include <boost/detail/endian.hpp>
> ./boost/archive/impl/basic_binary_iarchive.ipp
> #include <boost/detail/endian.hpp>
> ./boost/detail/limits.hpp
> #include <boost/detail/endian.hpp>
> ./boost/math/special_functions/detail/fp_traits.hpp
> #include <boost/detail/endian.hpp>
> ./boost/mpl/string.hpp
> #include <boost/detail/endian.hpp>
> ./boost/spirit/home/support/detail/endian/endian.hpp
> #include <boost/detail/endian.hpp>
> ./boost/spirit/home/support/detail/math/detail/fp_traits.hpp
> #include <boost/detail/endian.hpp>
> ./libs/math/example/inspect_fp.cpp
>
The question intention was to assign it to the library you are using so 
that the ticket is taken by the author using this internal library. I 
you left it associated to the None component, None will take care of it.

HTH,
Vicente