Re: [boost] [gil::io] Feedback for scanline_read_iterator

Subject: Re: [boost] [gil::io] Feedback for scanline_read_iterator
From: Christian Henning (chhenning_at_[hidden])
Date: 2013-02-21 20:09:11

>
> I had a quick look, and I immediately noticed that you (still, I guess?)
> are incrementing the _pos member upon dereferencing the first time...is
> there some reason you don't increment it unconditionally in operator++? I'm
> guessing the end result is the same, given the pair of boolean flags
> encoding the state, but it's a "code surprise", which increases the
> cognitive overhead to read it :)
>

This issue has been fixed. I don't need to increase the position
anymore in the operator*.

Thanks!

Christian