Re: [boost] [1.54] [thread] MSVC build broken

Subject: Re: [boost] [1.54] [thread] MSVC build broken
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2013-06-15 07:02:06

Le 15/06/13 12:23, Andrey Semashev a écrit :
> Hi,
>
> I've noticed that my Boost.Log tests on MSVC are failing massively. The build
> log hints that Boost.Thread might be the culprit, and its tests are also
> failing on MSVC with the following error:
>
> ..\boost/thread/future.hpp(1127) : error C2248:
> 'boost::unique_lock<Mutex>::operator =' : cannot access private member
> declared in class 'boost::unique_lock<Mutex>'
>          with
>          [
>              Mutex=boost::mutex
>          ]
>          ..\boost/thread/lock_types.hpp(110) : see declaration of
> 'boost::unique_lock<Mutex>::operator ='
>          with
>          [
>              Mutex=boost::mutex
>          ]
>
> This is happening on release branch. Could this be fixed?
>
>
Hi,

I have no access to a windows machine now.

There were this change set 
https://svn.boost.org/trac/boost/changeset/84750 that could be related.

Please could you try to revert this and let me know if this is the 
source of the problems?

Index: branches/release/boost/thread/detail/delete.hpp
===================================================================
--- a/branches/release/boost/thread/detail/delete.hpp
+++ b/branches/release/boost/thread/detail/delete.hpp
@@ -24,4 +24,15 @@
  
  #else // BOOST_NO_CXX11_DELETED_FUNCTIONS
+#if defined(BOOST_MSVC)
+#define BOOST_THREAD_DELETE_COPY_CTOR(CLASS) \
+    private: \
+      CLASS(CLASS const&); \
+    public:
+
+#define BOOST_THREAD_DELETE_COPY_ASSIGN(CLASS) \
+    private: \
+      CLASS& operator=(CLASS const&); \
+    public:
+#else
  #define BOOST_THREAD_DELETE_COPY_CTOR(CLASS) \
      private: \
@@ -33,4 +44,5 @@
        CLASS& operator=(CLASS&); \
      public:
+#endif
  #endif // BOOST_NO_CXX11_DELETED_FUNCTIONS

Best,
Vicente