Subject: Re: [boost] Permission to proceed?
From: Daniel James (daniel_at_[hidden])
Date: 2013-10-12 11:11:23
On 12 October 2013 14:19, Stephen Kelly <steveire_at_[hidden]> wrote:
> On 10/11/2013 11:49 PM, Rene Rivera wrote:
>> In this case we wanted to hold off on trunk commits that had a high
>> probability of breaking many things while we worked on the beta. As people
>> needed to get test cycled as quickly as possible.
> You mean 'high risk', not 'high possibility'. No breakage from those
> patches yet :).
Sadly, that doesn't mean much. The test results haven't updated since
Thursday and a lot of libraries aren't checked regularly. For one
example, iostreams is mostly unmaintained, although I occasionally
review patches. I had a quick look at the changes, and noticed this in
-#if !BOOST_WORKAROUND(BOOST_MSVC, < 1310)
+#if !BOOST_WORKAROUND(BOOST_MSVC, == 1310)
Which looks wrong to me. That was on the second screen of the changes,
and there are a lot more screens after that. The rest of it might be
fine, but it's unlikely that they'll get checked soon.
Also, I asked you not to make these changes until after the release
was made here:
Which you seemed to agree to. We should wait for a little while after
the release to give people a chance to respond to the release notes.
You also should notify library maintainers before making non-trivial
changes to their libraries.