Re: [boost] Review request: Require a SFINAE capable compiler

Subject: Re: [boost] Review request: Require a SFINAE capable compiler
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2013-10-13 07:45:18

Le 13/10/13 13:00, Vicente J. Botet Escriba a écrit :
> Le 12/10/13 10:06, Stephen Kelly a écrit :
>> Hello,
>>
>> Several of the ancient compilers define BOOST_NO_SFINAE.
>>
>> The attached patch removes support for those versions of the compilers
>> which are not capable of SFINAE.
>>
>> This bumps the compiler requirement to remove support for Borland 5.x,
>> Metrowerks prior to 9.0, and SunPro prior to 5.7. Compilers based on EDG
>> 238 are also affected, though it is unknown what those are.
>>
>> Ok to commit?
>>
>>
> Please, wait for at least John give you permission.
>
> BTW, Could you add the patch to the documentation concerning 
> BOOST_NO_SFINAE has been removed.
>
> How many libraries are concerned by this change?
> Could you give the list so that the authors/maintainers of these 
> libraries could take a look at your patch?
>
Just a minor typo

  #   if(__MWERKS__ <= 0x3207) || !defined(BOOST_STRICT_CONFIG) // 9.6
@@ -129,7 +109,7 @@
  //
  // versions check:
  // we don't support Metrowerks prior to version 5.3:
-#if __MWERKS__ < 0x2301
+#if __MWERKS__ < 0x3207
  #  error "Compiler not supported or configured - please reconfigure"
  #endif

This comment
  // we don't support Metrowerks prior to version 5.3:
should be
  // we don't support Metrowerks prior to version 9.6, isn't it?:

Why this line
-#define BOOST_NO_SFINAE
has been removed in

diff --git a/boost/config/compiler/digitalmars.hpp 
b/boost/config/compiler/digitalmars.hpp
index 7de6adb..20c2dcc 100644
--- a/boost/config/compiler/digitalmars.hpp
+++ b/boost/config/compiler/digitalmars.hpp
@@ -15,7 +15,6 @@
  #define BOOST_NO_MEMBER_TEMPLATE_FRIENDS
  #define BOOST_NO_OPERATORS_IN_NAMESPACE
  #define BOOST_NO_UNREACHABLE_RETURN_DETECTION
-#define BOOST_NO_SFINAE
  #define BOOST_NO_USING_TEMPLATE
  #define BOOST_FUNCTION_SCOPE_USING_DECLARATION_BREAKS_ADL
  #endif

Best,
Vicente