Boost logo

Boost :

Subject: Re: [boost] [build] Headers rule does both too much and too little
From: Ahmed Charles (acharles_at_[hidden])
Date: 2014-02-18 15:35:09


---------------------------------------- > Date: Tue, 18 Feb 2014 19:10:30 +0000 > From: boost.regex_at_[hidden] > To: boost_at_[hidden] > Subject: Re: [boost] [build] Headers rule does both too much and too little > > > > On 18/02/2014 19:03, Peter Dimov wrote: >> Steven Watanabe wrote: >>> AMDG >>> >>> On 02/18/2014 09:39 AM, Peter Dimov wrote: >>>> >>>> I don't know how smart b2's scanner is; my simplistic one would be >>>> fooled by >>>> >>>> /**/#include <boost/test/test_tools.hpp> >> ... >> >>> The pattern is "#[ \t]*include[ ]*(<(.*)>|\"(.*)\")" (no anchors), so >>> this will match. >> >> This will match >> >> // #include "something.hpp" >> >> then? >> >> OK, I change my suggestion to >> >> #/**/include <boost/test/test_tools.hpp> > > Probably over-complicated: the inclusion of Boost.Test is I believe a > relic from the time when all the type-traits tests could be built as one > big test program. I think they've gone beyond that now, so some cleanup > is probably in order. I'd prefer to not try to trick the dependency scanner into thinking there isn't a dependency, when in fact, there is one. If this include shouldn't be there, then it should be removed, but as long as it's there, is should be tracked as a dependency and if it changes, the test should be rebuilt.


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk