Re: [boost] 1.56.0 beta release candidate 2 available for testing

Subject: Re: [boost] 1.56.0 beta release candidate 2 available for testing
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2014-07-16 10:26:19

On Jul 16, 2014, at 5:31 AM, Bjørn Roald <bjorn_at_[hidden]> wrote:

> On 07/16/2014 02:24 PM, Andrey Semashev wrote:
>> On Wed, Jul 16, 2014 at 3:44 PM, Bjørn Roald <bjorn_at_[hidden]> wrote:
>>> On 07/15/2014 06:58 PM, Marshall Clow wrote:
>>>> 
>>>> The second release candidate files for 1.56.0 beta are available at
>>>> http://boost.cowic.de/rc/
>>> 
>>> clang -std=c+11 seems to satisfy:
>>> 
>>> #if defined( __GNUC__ ) && __GNUC__ * 100 + __GNUC_MINOR__ <= 404
>>> 
>>> in ./boost/smart_ptr/detail/sp_forward.hpp and thus select sp_forward
>>> template that by comments looks like workaround for GCC 4.4 outdated version
>>> of rvalue references.
>>> 
>>> The test should should be changed to:
>>> 
>>> #if defined( __GNUC__ ) && __GNUC__ * 100 + __GNUC_MINOR__ <= 404 && not
>>> defined __clang__
>>> 
>>> or
>>> 
>>> #if defined( __GNUC__ ) && __GNUC__ * 100 + __GNUC_MINOR__ <= 404 && not
>>> defined BOOST_CLANG
>>> 
>>> or use a Boost.Config feature test if it exist for this.
>> 
>> That was my mistake, I'll prepare a pull request to fix this.
> 
> thanks, for the sake of consistency, maybe better to use "&& !defined( __clang__ )"
> 
> I tested both gcc and clang with and without -std=c++11 with the test like this, and boost builds successfully.
> 
> #if defined( __GNUC__ ) && __GNUC__ * 100 + __GNUC_MINOR__ <= 404 && !defined( __clang__ )

I don’t think that this is a big enough problem to hold up the release of the beta.
What do you think?

[ Note: Beta != final release. That comes in a couple weeks, and we certainly want this fixed for that. ]

— Marshall