Re: [boost] [units] Pull request and RFC: information unit definitions for Boost.Units

Subject: Re: [boost] [units] Pull request and RFC: information unit definitions for Boost.Units
From: Gonzalo BG (gonzalobg88_at_[hidden])
Date: 2014-08-27 06:49:49

On Wed, Aug 27, 2014 at 12:21 PM, Jürgen Hunold <jhunold_at_gmx.eu> wrote:
> - Documentation:
> - (Examples)

I'll add a small section to the documentation with an constexpr example.
The (automatically generated?) API reference documentation already includes
the BOOST_CONSTEXPR in the data-types member functions which should be
self-explanatory. I'll ping you when I update the PR and we can discuss
there how to improve the documentation further but basically either you can
use Boost.Units in constant expressions or you can't.

> - Tests

I have some unit-tests but removed them because I wasn't able to enable
them only for compilers with constexpr support (otherwise they will fail to
compile).  Boost.Build/Boost.Test documentation wasn't very helpful in this
regard. I just went through Boost.Array develop branch and found:

https://github.com/boostorg/array/blob/develop/test/array_constexpr.cpp

Should I implement the constexpr tests in a similar manner or do anything
differently?

> And I'd like a snappy sentence to add to the release notes.

I'll add "Boost.Units has gained constexpr support." to the commit message.

> - The patch also changes unrelated whitespace like line-endings, removes
empty
> lines and changes wrapping. This should go into a separate pull request if
> necessary.
> - The patch also removes some code blocks currently commented out. This
should
> be done in a separate request, too.

I was just following the boy scout rule but will revert them.
I won't create a new pull-request with these but I since navigating the
code in a 80char terminal was a bit unpleasant I would be happy if you
consider some of them in the future.

Bests,
Gonzalo

>