Re: [boost] [Fusion] Lots of test failures on develop

Subject: Re: [boost] [Fusion] Lots of test failures on develop
From: Louis Dionne (ldionne.2_at_[hidden])
Date: 2014-11-11 18:01:08

Joel de Guzman <djowel <at> gmail.com> writes:

> 
> On 11/12/14, 12:04 AM, Louis Dionne wrote:
> > I'm getting a lot of test failures on the develop branch of Fusion on OS X.
> >
> > There are too many to paste the output here. Note that master is just 
> > fine. Are the unit tests being run automatically each time a pull request 
> > is merged?
> 
> Which compiler? All tests pass at least on Clang here. I just did a
> sync and full test. I'll look into this, Louis. There's been a lot
> of clean up and bug fixing code changes lately. Thanks for reporting,
> Louis.

That was on Apple's Clang. It turned out that the problem was the
BOOST_CXX14_CONSTEXPR macro being used without ever being
defined (I grepped all of Boost for it and couldn't find a definition).
I replaced it by BOOST_CONSTEXPR, which is used in a lot of other
places and is most likely what the author of the faulty commit intended.

I'll be creating a pull request in the next minutes.

Louis