Re: [boost] [Review] Boost.Endian mini-review

Subject: Re: [boost] [Review] Boost.Endian mini-review
From: Rob Stewart (rob.stewart_at_[hidden])
Date: 2015-01-29 13:53:18

On January 23, 2015 11:17:25 AM EST, Joel FALCOU <joel.falcou_at_[hidden]> wrote:
> The mini-review of Boost.Endian starts today and runs through Sunday,
> February 1.
> 
> The docs for the library can be viewed online at
> https://boostorg.github.io/endian/

I found a few issues on the docs:

* "an class"
* "may improved efficiency"
* " Remarks: Meet the EndianReversible requirements", for endian_reverse() should, I assume, refer to "x"
* should there be a note suggesting that the following be constexpr, when possible?

template <class EndianReversible> EndianReversible conditional_reverse(EndianReversible x, order order1, order order2) noexcept;

* The effects documented for endian_reverse_inplace() don't allow for specialization.

 The code type is much smaller than the surrounding text. This is particularly odd, besides annoying, on the specifications section in which the effects, remarks, etc. Are huge compared to the function declaration to which they relate.
I
___
Rob

(Sent from my portable computation engine)