Subject: Re: [boost] [MPL] Advice on how to proceed with a bugfix pull request
From: Bruno Dutra (brunocodutra_at_[hidden])
Date: 2015-02-08 16:04:48
As I replied to your comments on Ticket#7769, I avoided defining a new
macro to avoid breaking some rule, naming convention or anything of the
sort that I might be unaware of, but I guess it entails unnecessary
overhead. I think I'll just go ahead and use the name you suggested and
then I'll file a pull request.
Thank you for your advice.
*Bruno C. O. Dutra*
2015-02-08 18:30 GMT-02:00 Edward Diener <eldiener_at_[hidden]>:
> On 2/8/2015 10:30 AM, Bruno Dutra wrote:
>> Hello everyone,
>> I've found a fix to this bug
>> <https://svn.boost.org/trac/boost/ticket/7769#no3>, which is based on
>> PP library and thus should be supported across the various platforms, even
>> though I just tested for a specific set up as I mentioned on my comment
>> there. I've added some code snippets, from which it is straightforward to
>> develop a patch, but I guess it would be best if I just issued a pull
>> request myself.
>> Since this is my first time contributing to MPL and to BOOST itself for
>> that matters, I'd like to first hear some advice on how to do this
>> properly. For instance, to which branch should I issue the pull request?
>> the way, is this indeed the best way to proceed at all?
> I have updated your proposal for a fix. Please take a look at my updated
> comments. if you want to proceed with a pull request go right ahead, else I
> will look to address this issue as my time warrants. Thanks for coming up
> with a fix.
> Unsubscribe & other changes: http://lists.boost.org/
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk