Re: [boost] [log] custom architecture and address-model

Subject: Re: [boost] [log] custom architecture and address-model
From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2015-02-19 06:01:09

On Thu, Feb 19, 2015 at 1:34 PM, Vladimir Prus
<vladimir_at_[hidden]> wrote:
> On 02/19/2015 12:31 PM, Andrey Semashev wrote:
>>
>> Could you explain what is the problem with these features and what is
>> the proposed fix?
>
> Andrey,
>
> the primary problem is that of code duplication. You have this:

[snip]

> and this is exactly equivalent to what libs/context/build/architecture.jam
> has, and
> which I'm moving to top level - except that is uses <log-address-model>, and
> not
> <address-model>. Code duplication is obviously bad, and having two features,
> address-model
> and log-address-model, seems also confusing.

Totally agree about duplication. It seems Boost.Log code is indeed the
same as Boost.Context.

> Would there be any reason for log-address-model and the if address-model is
> automatically set?

If log-address-model is the same as the automatically set one, there
is no reason to keep it.

Could you prepare a pull request please? Thanks.