Boost logo

Boost :

Subject: Re: [boost] enhanced vector and deque competency test
From: Giacomo Drago (giacomo_at_[hidden])
Date: 2015-03-19 15:56:47


On 2015-03-19 18:18, Islam Taha wrote:
> Hi,
> I am Islam Taha i’m interested in the idea of enhanced vector and deck and i’ve implemented
> the simple vector-like container, it would be pleasurable to review and give me your feedback
> on my implementation. that’s the link ( https://github.com/islam-taha/stdVector/blob/master/vector.cpp <https://github.com/islam-taha/stdVector/blob/master/vector.cpp> ).
> Thanks in advance.
>
> _______________________________________________
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
>

Hi, I had a brief look at your code, I didn't have time to inspect it
thoroughly. If I were you, I'd start by addressing the compile warnings
(compile with -Wall and keep on fixing them until there are none) and this:

   Vector<int> a;
   a.push_back(1);
   Vector<int> b(a);
   b[0] = 2;
   std::cout << a[0] << std::endl;

I also get a segfault somewhere but I can't debug it now.

Best
Giacomo


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk