Re: [boost] [ boost ] [ Trie ]

Subject: Re: [boost] [ boost ] [ Trie ]
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2015-04-10 15:43:58

2015-04-10 0:22 GMT+03:00 Cosmin Boaca <boost.cosmin.boaca_at_[hidden]>:

> I have removed pred/next_node fields from
> trie_node class [0]. What would you suggest to do next ?
>

Good!

I'd recommend to clean up boost/trie/detail/trie_node.hpp :
* `value_count` and `self_value_count` - are both members used in code?
* move `key`, `children` and `parent` to to a separate base class. Define
`operator<` and `comparator` only for that base class
* make all the accesses to `parent` member through functions
(`set_parent()`, `get_parent()`). This will simplify future
node-minimization work

-- 
Best regards,
Antony Polukhin