Subject: Re: [boost] [Boost-announce] [metaparse] Review period starts May 25th and ends June 7th
From: Abel Sinkovics (abel_at_[hidden])
Date: 2015-06-08 15:35:20
Thank you for the review.
On 2015-06-08 09:37, Michael Caisse wrote:
> I had some trouble using the on-line version of metashell. It kept
> timing out. I downloaded a recent version and struggled with the setup
> for a bit trying to get the include paths correct. Metashell is a very
> neat utility; however, you might want to add a quick start appendix
> for using Metashell (local version) with Metaparse considering the
> examples are illustrated using the tool.
I'll add that.
> - When renaming macros, please don't just change/replace MPLLIBS to
> BOOST. There are several (all?) (MPLLIBS_STRING, MPLLIBS_DEFINE_ERROR,
> ...) where this isn't going to work. Perhaps BOOST_MPARSE_ would be a
> good replacement. I'm not opposed to BOOST_METAPARSE_.
Sure, they won't remain BOOST_STRING, BOOST_DEFINE_ERROR, etc).
> - Helper include files are nice. metaparse/all.hpp or something like
> that. I find when I an first working out a solution that having
> everything included allows me to just concentrate on the grammar
> details. The calculator_with_parens_and_unary_ops example has 16
> individual metaparse includes!
I'll add a metaparse.hpp that includes everything. I think that is the
most straight forward thing to do here.
> I believe others have also mentioned the "...>" prompt in the
> metashell examples results in some initial confusion.
The first time it appears in the tutorial, it might be explained. I find
the "...>" prompt making it clear what the user is supposed to type and
what the response is (or is expected to be). With the links to the
copy-paste friendly version of the code examples, they should be fine.
> Jamfiles had to be modified to force c++11 mode and a larger template
Is there a way of telling the Jamfiles to use c++11/c++14 if supported?
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk