Re: [boost] [AFIO] Formal review

Subject: Re: [boost] [AFIO] Formal review
From: Asbjørn (lordcrc_at_[hidden])
Date: 2015-09-02 19:34:23

On 03.09.2015 01:21, Niall Douglas wrote:
> On 2 Sep 2015 at 23:20, Asbjørn wrote:
 >
>> That said, as a humble Boost user, native_handle() returning void* sounds a bit
>> iffy to me. Why is it a pointer if it does not point to anything but should
>> rather be casted to the appropriate type by the user?
>
> Old habits of a C programmer: void * is for any "carry maximum
> information". Besides, there is form: Boost.Python defines the
> standard opaque Python-can't-understand-this type as a void * (I
> contributed the implementation myself a very long time ago).

Yeah I can understand that.

However personally, again as a humble Boost user, I would prefer if you "dress 
it up" by a typedef so that in the docs and user code there is no mention of 
this being a void*. This would be a bit similar to ASIO's "native_handle_type".

Cheers
- Asbjørn