|
Boost : |
Subject: Re: [boost] Boost.Fiber mini-review September 4-13
From: AgustÃn K-ballo Bergé (kaballo86_at_[hidden])
Date: 2015-09-07 12:31:10
On 9/7/2015 1:21 PM, Oliver Kowalke wrote:
> 2015-09-07 18:19 GMT+02:00 Oliver Kowalke <oliver.kowalke_at_[hidden]>:
>
>> 2015-09-07 18:11 GMT+02:00 AgustÃn K-ballo Bergé <kaballo86_at_[hidden]>:
>>
>>> On 9/4/2015 12:14 PM, Nat Goodspeed wrote:
>>>
>>>> docs: http://olk.github.io/libs/fiber/doc/html/index.html
>>>> git: https://github.com/olk/boost-fiber
>>>>
>>>
>>> Which branch are we supposed to be reviewing? I assumed the _master_
>>> branch, but I notice some code I looked at on Friday has changed since then.
>>>
>>
>> oh - sorry my mistake, I incorporate requested changes in branch develop.
>>
>
> == I modified the code regarding to std::chrono as you have suggested
> (branch develop)
You have just merged develop to master yet again, and the code I was
currently trying to understand changed yet again (something got renamed
I think?). Please **please** keep a stable branch for review, it doesn't
need to be _master_. Changes to address feedback are welcomed, but
please don't merge those to the branch under review as those are pretty
disruptive.
Regards,
-- AgustÃn K-ballo Bergé.- http://talesofcpp.fusionfenix.com
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk