Re: [boost] 1.59 release notes don't mention new property_tree::json_parser

Subject: Re: [boost] 1.59 release notes don't mention new property_tree::json_parser
From: Edward Diener (eldiener_at_[hidden])
Date: 2015-09-10 17:14:10

On 9/10/2015 12:26 PM, Jonathan Wakely wrote:
> On 10 September 2015 at 07:47, Viktor Sehr wrote:
>> Same thing happened to me, suddenly my application stopped to work. I
>> really think it should accept comments.
>
> A parser option to allow/disallow comments would be nice, but at a
> minimum the breaking change should be documented in the release notes,
> not buried away in git commit logs.

I totally agree with this. Any breaking change to a library should go 
into the release notes at the least. IMO it should also be emphatically 
mentioned in the docs of that library also.

>
>
>
>> /Viktor
>>
>> On Wed, Sep 2, 2015 at 7:18 PM Jonathan Wakely <jwakely.boost_at_[hidden]>
>> wrote:
>>
>>> The commit logs say:
>>>
>>>      TL;DR: The new parser fixes long-standing bugs and has full
>>> Unicode support, but removes non-standard extensions
>>>     of the old parser, which could break code:
>>>     - String concatenation: the old parser concatenated adjacent string
>>> literals like C does.
>>>     - Comments: the old parser supported C and C++-style comments. JSON
>>> doesn't allow comments.
>>>
>>>
>>> Removing support for comments did break something. Unfortunately there
>>> was no sign of this in the release notes, so I had to debug it the
>>> hard way (in code that swallowed the exception from the parser - gah!)
>>> and only found the commit message once I already knew what the problem
>>> was.
>>>
>>> </rant>