Re: [boost] [GitHub] [PR] setting default branch to 'develop'

Subject: Re: [boost] [GitHub] [PR] setting default branch to 'develop'
From: Vladimir Prus (vladimir.prus_at_[hidden])
Date: 2015-10-29 02:33:11

On 29-Oct-15 4:07 AM, Louis Dionne wrote:
> Vladimir Prus <vladimir.prus <at> gmail.com> writes:
>
>>
>> On 28-Oct-15 6:20 AM, Michel Morin wrote:
>>> Beman Dawes wrote:
>>>> Is it possible to write a curl script that could make the change for all
>>>> libraries?
>>>
>>> Like this
>>>
>>> [...]
>>>
>>> ?
>>> (You need to set USERNAME and PASSWORD in some way before using the command.)
>>
>> I have ran the above, with some quoting fixes:
>>
>> [...]
>>
>> This has updated every repo that is included in master. I've updated hana
>> by hand.
>>
>> Is this fine with everybody?
>
> No, it isn't. The only way of getting Hana right now is by cloning it from
> GitHub. By making the default branch `develop`, you automatically make any
> script that uses `git clone https://github.com/boostorg/hana` clone the
> `develop` branch, and thus potentially clone something broken.
...
> In general, I don't think defaulting pull-requests to master is a sufficient
> argument for changing the default branch. There is a nice CONTRIBUTING
> file at the root of the project telling people to pull-request against
> develop, and I am always free to close pull-requests that do not follow
> this advice. That being said, I don't care much about what is done for other
> libraries, but I do care about Hana. Hence, please revert the default branch
> to master for Hana.

I have set default branch for Hana back to master.

That said, I believe that once Hana is included in Boost releases, the decision
about default branch should be made depending on what is right for users of Boost.
Which, I believe, is to have default branch be 'develop'. Somebody who contributes
to Boost is a whole should not be forced to read files in individual repositories
to figure out which branch to send pull requests too.

- Volodya

-- 
Vladimir Prus
http://vladimirprus.com