Re: [boost] [fiber] ready for next review

Subject: Re: [boost] [fiber] ready for next review
From: Agustín K-ballo Bergé (kaballo86_at_[hidden])
Date: 2015-12-03 16:21:18

On 12/3/2015 5:50 PM, Oliver Kowalke wrote:
> 2015-12-03 21:45 GMT+01:00 Agustín K-ballo Bergé <kaballo86_at_[hidden]>:
>
>> On 12/3/2015 3:49 PM, Oliver Kowalke wrote:
>>
>>> 2015-12-03 13:26 GMT+01:00 Agustín K-ballo Bergé <kaballo86_at_[hidden]>:
>>>
>>> Where can we find the documentation that corresponds to this branch?
>>>
>>>>
>>>>
>>> http://olk.github.io/libs/fiber/doc/html/
>>>
>>
>> Is this the one that corresponds to the develop branch? I looked for three
>> specific mistakes that I raised during the review, but nothing seems to
>> have changed there...
>>
>
> in the documentation?

Yes, in the documentation. During the re-review process I raised three 
conceptual mistakes in the documentation, important things and not 
simply just typos. I see they are still there in the documentation that 
corresponds to the develop branch, where review feedback has supposedly 
been addressed.

So I went looking at the code, and while I do see some problems I 
reported have been addressed, others have not. Could you please just let 
us know exactly which pieces of feedback did you address and which did 
you decide to ignore, so that we can make sure nothing has been 
unintentionally fell through the cracks again? Thank you.

Regards,
-- 
Agustín K-ballo Bergé.-
http://talesofcpp.fusionfenix.com