Re: [boost] [hana] missing .gitattributes

Subject: Re: [boost] [hana] missing .gitattributes
From: Louis Dionne (ldionne.2_at_[hidden])
Date: 2016-02-25 17:32:44

Niall Douglas <s_sourceforge <at> nedprod.com> writes:

> 
> On 25 Feb 2016 at 1:59, Louis Dionne wrote:
> 
> > Thanks, I just added a .gitattributes file. I think it should do the trick,
> > but let me know if it does not. The file is on the develop branch.
> 
> After a late application of a .gitattributes it would be wise to 
> apply a round of 
> https://stackoverflow.com/questions/1510798/trying-to-fix-line-endings
> -with-git-filter-branch-but-having-no-luck/1511273#1511273. If 
> everything is fine it does no harm, if anything is off it saves a ton 
> of weirdness for your end users down the line.

I did it, but there's nothing to change. It seems like the line endings are 
already OK. But thanks for the heads up.

> Whilst doing a crlf conversion I'd also recommend a round of 
> clang-format, gets all the changes done at once. Add clang format to 
> your CI after that to keep your source code looking nice.

I tried setting up clang-format, but I could never get it to do exactly
what I wanted. It always changes stuff that I don't want it to, so I
eventually gave up.

Louis