Re: [boost] [Fit]Â formal review starts today

Subject: Re: [boost] [Fit] formal review starts today
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2016-03-05 03:36:33

Le 05/03/2016 01:11, Paul Fultz II a écrit :
>
> On Friday, March 4, 2016 at 5:19:52 PM UTC-6, Steven Watanabe wrote:
>> AMDG
>>
>> On 03/04/2016 11:55 AM, Vicente J. Botet Escriba wrote:
>>> Even if you are not for the library in its current state your comments
>>> will help a lot to improve it, so please, could you reconsider to give
>>> us more feedback on other parts of the library?
>>>
>>    I suspect that I'd be saying a lot of the
>> same things over again.  For example:
>>
>> #include <boost/fit/conditional.hpp>
>>
>> struct identity {
>>      template<class T>
>>      T operator()(T t) { return t; }
>> };
>>
>> int main() {
>>      boost::fit::conditional(identity(), identity())(0);
>> }
>>
>> 1> boost\fit\conditional.hpp(84): error C2500:
>> 'boost::fit::detail::conditional_kernel<F1,F2>': 'identity' is already a
>> direct base class
>> 1>          with
>> 1>          [
>> 1>              F1=identity,
>> 1>              F2=identity
>> 1>          ]
>> 1>
>>
> This is by design. I should document this. It makes absolutely no sense to
> pass the same function to conditional, and is most likely a mistake in the
> users code.
>   
Please, could you add an issue on github to document the design?

Vicente