Re: [boost] [Fit] Louis Dionne's formal review

Subject: Re: [boost] [Fit] Louis Dionne's formal review
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2016-03-11 20:04:50

Le 11/03/2016 23:32, Louis Dionne a écrit :
> First of all, sorry for submitting my review so late.
Thanks Louis for your review, which it is not late.

Thank also for creating the github issues.

We have yet all the weekend to work on FIt review.

Best,
Vicente

>>     
>>
>> Summary
>> -------
>> Fit should be accepted conditionally and re-submitted for a mini-review before
>> it can be accepted. My conditions are
>>
>> 1. Correctly justify the purpose of the library
>> 2. Resolve the issues on `capture` and `pack`'s semantics
>>
>> I think all the other points I raised are important too, but they shouldn't
>> refrain Fit from being accepted. I also trust that Paul would be willing to
>> continue working on the issues that were raised during this review if Fit
>> were to be accepted.
>>
>>