Re: [boost] [EXTERNAL] [1.61.0] Master branch is closed

Subject: Re: [boost] [EXTERNAL] [1.61.0] Master branch is closed
From: Belcourt, Kenneth (kbelco_at_[hidden])
Date: 2016-04-23 15:02:09

> On Apr 23, 2016, at 11:39 AM, Robert Ramey <ramey_at_[hidden]> wrote:
> 
> On 4/22/16 11:11 AM, John Maddock wrote:
>> 
>>> I'm willing to do whatever is most convenient for you guys.  Ideally
>>> I'd like to see at least a few test results on develop, merge to
>>> master and see at least a few results there.
>>> 
>> 
>> Running tests locally, msvc-14, 12 and 11 all pass.  With msvc-10 there
>> are 10 failures, but 7 shown on the test matrix, current failures are:
>> 
>> test_map_unordered_text_archive
>> test_map_unordered_text_warchive
>> test_map_unordered_xml_archive
>> test_map_unordered_xml_warchive
>> test_map_unordered_binary_archive
>> 
>> test_set_unordered_text_archive
>> test_map_unordered_text_warchive
>> test_map_unordered_xml_archive
>> test_map_unordered_xml_warchive
>> test_map_unordered_binary_archive
>> 
>> These all look to be the "same" failure though, so I'm not sure why some
>> of these seem to pass in the test matrix?
> 
> I'm aware of this.  But it seems specific to msvc 10 which I don't have. I presume that this will require some workaround for some problem in the msvc 10 standard library implementation.  I consider it low priority.
> 
>> 
>> GCC-5.3.0 mingw failures:
>> 
>> test_native_array_xml_warchive
>> test_registered_xml_warchive
>> test_boost_array_xml_warchive
>> test_non_default_ctor2_xml_warchive
>> test_delete_pointer_xml_warchive
>> test_unregistered_xml_warchive
>> test_dll_simple
> 
> On the test matrix, the serialization library fails with all compilers on the mingw platform.  I've asked about this on the build list a couple of times and gotten no response.  It's low priority.
> 
>> 
>> GCC 5.3.0 C++14 mode:
>> 
>> test_codecvt_null
>> test_array_xml_warchive
>> test_boost_array_xml_warchive
>> test_native_array_xml_warchive
>> test_binary_xml_warchive
>> test_bitset_xml_warchive
>> test_class_info_load_xml_warchive
>> test_complex_xml_warchive
>> test_contained_class_xml_warchive
>> test_cyclic_pointers_xml_warchive
>> test_delete_pointer_xml_warchive
> 
> I could not get my cygwin system to build and test the serialization library.  This particular error might be addressed by this pending high priority fix.
> 
>> 
>> + lots more, all with the same failure as:
>> http://www.boost.org/development/tests/develop/developer/output/timber-cygwin-boost-bin-v2-libs-serialization-test-test_mi_xml_warchive-test-gcc-5-3-0-debug.html

> 
> same as above.
>> 
>> 
>> Intel 16 win:
>> 
>> Almost everything fails with linker errors.
> 
> Hmm - the current develop test matrix only shows a couple of errors. All are linker errors apparently related to one function which is only used in a couple of cases.  Again - low priority.
> 
> I have this one fix.  It means that all xml output has an invalid ending tag on all tests/platforms etc.  I consider this as super high priority as anyone who were to use the library would be generating invalid xml files and sometimes storing them indefinitely.  I'd rather not imagine what the repercussions of this might be.  I'd rather not.
> 
> The other issues are corner cases on specific configurations.  I always have this.  I strive to diminish them every release.  In this round, I made the tests for output of non-ascii characters more stringent and implemented limited visibilty for gcc/clang compilers.  This generated a large number of new test failures.  This not an indicator of declining quality or regressions, but rather a side effect of insisting on a higher quality product.  I recognize that I can't make a perfect product.  I strive to make each version better than the previous one.
> 
> In any case, given that I haven't received any new information, I'll merge the change from develop into master

Hi Robert,

I noticed that all the Boost.MPI and graph parallel tests that use serialization are broken on develop and master with an error similar to this:

In file included from libs/graph_parallel/src/mpi_process_group.cpp:14:
In file included from ./boost/graph/distributed/mpi_process_group.hpp:30:
In file included from ./boost/mpi.hpp:32:
In file included from ./boost/mpi/skeleton_and_content.hpp:32:
./boost/mpi/detail/ignore_iprimitive.hpp:40:21: error: no template named 'array' in namespace 'boost::serialization'; did you mean simply 'array'?
    void load_array(serialization::array<T> &, unsigned int )
                    ^~~~~~~~~~~~~~~~~~~~
                    array
./boost/array.hpp:61:11: note: 'array' declared here
    class array {
          ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.

    "g++"  -ftemplate-depth-128 -O3 -Wall -gdwarf-2 -fexceptions -Wno-inline -arch x86_64  -DBOOST_ALL_NO_LIB=1 -DBOOST_GRAPH_NO_LIB=1 -DNDEBUG  -I"." -I"/Users/kbelco/Projects/local/openmpi-1.8.4/include" -I"libs/graph_parallel/src" -c -o "bin.v2/libs/graph_parallel/build/darwin-4.2.1/release/link-static/threading-multi/mpi_process_group.o" "libs/graph_parallel/src/mpi_process_group.cpp”

It’d be nice if serialization worked with MPI for the release, though I’m not sure it’s a show stopper.

— Noel