Subject: Re: [boost] [1.61.0] Master branch is closed
From: Vladimir Prus (vladimir.prus_at_[hidden])
Date: 2016-04-23 15:44:04
On 4/21/2016 8:17 PM, Vicente J. Botet Escriba wrote:
> Le 21/04/2016 08:39, Vladimir Prus a Ã©crit :
>> On 4/21/2016 1:24 AM, Vicente J. Botet Escriba wrote:
>>> Le 20/04/2016 21:17, Vladimir Prus a Ã©crit :
>>>> The master branch is now closed for all changes, except by permission from a release manager.
>>>> Per schedule, the branch will be totally frozen on Saturday.
>>> I've come back from vacations (last Sunday) and I believed that the version 1.61 was already released.
>>> I have fixed two major bugs and some doc issues that I would like to merge into the master branch.
>>> Could I do the merge on Friday if the develop regressions are good?
>> you've listed quite a large number of changes in your email, including some merge commits. This
>> looks like too large change to merge when the master branch is closed. Possibly, you've copy-pasted
>> something from GitHub interface, and it did not came across as intended.
>> If you believe there are truly horrible bugs that would regress boost.thread, could you specifically
>> list those bugs, along with commits fixing those bugs specifically - and we can cherry-pick those
>> changes if so warranted.
>>> The commits are the following:
>>> committed 12 minutes ago
>> In particular, the above appears to show all your commits on develop, not any
>> particular commit, so it's hard to understand what you're proposing to merge.
> Sorry, there were some pull merge that I need to fix and a lot of minor doc changes.
> BTW this commit
> * hiden typo (cosmetic)
> The last one introduced two new files that are not used and I've removed in
I don't think that fixing a typo is a necessary patch at this point.
> * fix memory leak (BUG - robustness)
These seem safe and important, so you can cherry-pick them. For avoidance of doubt,
I mean specifically using "git cherry-pick <commit>", where commit is one of 3 above.
> * call interrupt only if joinable. (optimization cosmetic)
If it is cosmetic, can it wait for next release?
> * call on_desctruction on scoped_thread move assignment. (BUG - showstopper for scoped_thread )
This one is a documentation change. Is it really showstopper, or you meant some other commit?
-- Vladimir Prus http://vladimirprus.com
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk