Subject: [boost] [process] Formal review results
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2016-11-09 13:45:19
The Boost.Process library is accepted.
Congratulations to Klemens, and thanks to everybody who reviewed the library!
The votes were as follows:
- Niall Douglas
+/- Tom Kent
+/- Nat Goodspeed
+ Paul A. Bristow
+/- Bjorn Reese
+ Edward Diener
+ Boris SchÃ¤ling
+/- RaphaÃ«l Londeix
+ Klaim - JoÃ«l Lamotte
+/- accept conditionally
Separate thanks to Gavin Lambert for providing a solution to
Additional thanks to Nat Goodspeed, Niall Douglas, Gavin Lambert,
RaphaÃ«l Londeix and Bjorn Reese for spending significant amount of
time on discussing, reviewing or testing the library.
-- Quick review summary --
During the review multiple technical issues were raised and as far as
I know, Klemens already working on them. The biggest win of the review
- is a fix for possible deadlock with pipes.
The most controversial part of the library is it's interface. Many
comments were addressing:
* passing arguments
* starting process right in `system(...)` function
Current approaches have benefits and drawbacks, other approaches have
different benefits and drawbacks. At this point some people agree that
the current approach is the lesser evil.
Reviewers also wished to have better/richer documentation.
P.S.: Please continue with the discussion and report issues that would
help to improve the library.
-- Best regards, Antony Polukhin