Re: [boost] [Stacktrace] Second review begins today 17th Mar ends 26th Mar

Subject: Re: [boost] [Stacktrace] Second review begins today 17th Mar ends 26th Mar
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2017-03-18 10:38:28

2017-03-17 19:50 GMT+03:00 Peter Dimov via Boost <boost_at_[hidden]>:
>> You can find the documentation at
>> http://apolukhin.github.io/stacktrace/index.html and the github repo
>> at https://github.com/apolukhin/stacktrace.
>
>
> Some Cygwin errors:
>
> In file included from
> ..\..\../boost/stacktrace/detail/frame_unwind.ipp:19:0,
>                 from ..\..\..\libs\stacktrace\build\..\src\addr2line.cpp:10:
> ..\..\../boost/stacktrace/detail/location_from_symbol.hpp:25:7: error:
> 'Dl_info' in namespace '::' does not name a type
>     ::Dl_info dli_;
>       ^
>
> ..\..\../boost/stacktrace/detail/location_from_symbol.hpp:31:14: error:
> '::dladdr' has not been declared
>         if (!::dladdr(addr, &dli_)) {
>              ^
> Cygwin doesn't have Dl_info and dladdr.

Why id does not define the BOOST_WINDOWS macro?

> ..\..\../boost/stacktrace/detail/frame_msvc.ipp:97:36: error: '<::' cannot
> begin  a template-argument list [-fpermissive]
>
> ..\..\../boost/stacktrace/detail/frame_msvc.ipp:97:36: note: '<:' is an
> alternate spelling for '['. Insert whitespace between '<' and '::'
>
> Digraphs are fun. :-)

Fixed in develop.

-- 
Best regards,
Antony Polukhin