Re: [boost] [Stacktrace] Second review begins today 17th Mar ends 26th Mar

Subject: Re: [boost] [Stacktrace] Second review begins today 17th Mar ends 26th Mar
From: Emil Dotchevski (emildotchevski_at_[hidden])
Date: 2017-03-20 03:10:42

On Sun, Mar 19, 2017 at 6:42 PM, Edward Diener via Boost <
boost_at_[hidden]> wrote:

> On 3/19/2017 7:30 PM, Niall Douglas via Boost wrote:
>
>> Peter did not suggest not using windows.h itself AFAICS. He just
>>> suggested that stacktrace functionality which does not need it be
>>> segregated into specific headers which do not include it. Furthermore if
>>> stacktrace still has the general header, and promotes the use of it,
>>> rather than specific headers, that's fine as long as the end-user has a
>>> choice. OTOH if stacktrace functionality which appears not to need the
>>> constructs in windows.h still does need it under the covers in the
>>> header only version of the library, then I understand Antony's objection.
>>>
>>
>> If you choose the null backend, then yes windows.h should not be included.
>>
>> If you choose the non-null backend, which needs to open up a COM session
>> with the Debug Engine to debug the calling executable, I think windows.h
>> (and the COM headers which are also massive) pretty hard to avoid.
>>
>
> Choosing only the windbg backend needs COM. I am still arguing along with
> Peter that merely choosing the windbg backend, or having it automatically
> chosen for me when I am using VC++, should not bring in windows.h until it
> is actually needed by the code I am invoking either in the stacktrace or
> frame classes.
>

+1

Emil