Boost logo

Boost :

Subject: Re: [boost] [Convert] std::isspace requires unsigned #28
From: Vladimir Batov (Vladimir.Batov_at_[hidden])
Date: 2017-03-20 08:46:43


Olaf,

On 2017-03-20 19:10, Olaf van der Spek via Boost wrote:
>
>> boost\convert\base.hpp(112): warning C6330: 'const char' passed as
>> _Param_(1) when 'unsigned char' is required in call to 'isspace'.
>
>> boost\convert\base.hpp(115): warning C6330: 'const char' passed as
>> _Param_(1) when 'unsigned char' is required in call to 'isspace'.
>
> https://github.com/boostorg/convert/issues/28
>
> IMO the code should be fixed and it's not a documentation issue.
> What do you think?

We discussed it on https://github.com/boostorg/convert/issues/28.

I even thought we've come to the same conclusion that is comes down to
documentation. With you saying: "OK, so where are those preconditions of
boost::convert documented?" and me agreeing to address that in the docs
as you asked. Clearly I misunderstood. :-)


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk