Re: [boost] [Beast] Questions Before Review

Subject: Re: [boost] [Beast] Questions Before Review
From: Vinnie Falco (vinnie.falco_at_[hidden])
Date: 2017-06-26 16:25:11

On Mon, Jun 26, 2017 at 9:15 AM, Niall Douglas via Boost
<boost_at_[hidden]> wrote:
>> * PicoHTTPParser, which Beast's parser is based on, outperforms NodeJS
>> by over 600% [2]
>
> If used as its author intended. I didn't get the impression the author
> expected to you memcpy its input.

phr_parse_request() requires the entire header in a single contiguous
memory buffer [1]

> Why?
> ...
> LLVM doesn't do this. So why should Beast?

Answered already [2]

[1] https://github.com/h2o/picohttpparser/blob/2a16b2365ba30b13c218d15ed9991576358a6337/picohttpparser.h#L51

[2] http://boost.2283326.n4.nabble.com/Beast-Questions-Before-Review-tp4696141p4696160.html