Re: [boost] [review][beast] Review of Beast starts today : July 1 - July 10

Subject: Re: [boost] [review][beast] Review of Beast starts today : July 1 - July 10
From: Paul A. Bristow (pbristow_at_[hidden])
Date: 2017-07-13 08:34:13

> -----Original Message-----
> From: Boost [mailto:boost-bounces_at_[hidden]] On Behalf Of Vinnie Falco via Boost
> Sent: 13 July 2017 04:40
> To: Boost
> Cc: Vinnie Falco
> Subject: Re: [boost] [review][beast] Review of Beast starts today : July 1 - July 10
> 
> On Sun, Jul 9, 2017 at 9:38 AM, Daniela Engert via Boost
> <boost_at_[hidden]> wrote:
> >  * Beast's zlib emits a few harmless but stupid warnings C4127
> > "conditional expression is constant" (Microsoft, get rid of them!) and
> > quite some narrowing warnings C4244. These need some cleansing before we
> > can use Beast in our team because of our /W4 /WX policy.
> 
> The last of the warnings has been fixed, 

:-)

> this one was incredibly annoying! 

They all are!

> Nik helped, he came up with calling is_initialized()
> (the guidance on the boost page was insufficient):
> 
> <https://github.com/vinniefalco/Beast/pull/639>

I couldn't see the changes needed from this.

If either of you have a moment to explain briefly what is missing from the guidance note

https://svn.boost.org/trac10/wiki/Guidelines/WarningsGuidelines

then I'll update it.

This may save others from being incredibly annoyed ;-)

Paul

---
Paul A. Bristow
Prizet Farmhouse
Kendal UK LA8 8AB
[phone]